Update descriptions of disabled output handler #3839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmb69
reviewed
Oct 6, 2024
reference/outcontrol/constants.xml
Outdated
| or fails while processing the buffer, | ||
| or it was set prior to calling the output handler. | ||
| or fails while processing the buffer. | ||
| Prior to PHP 8.4.0, this flag can be set when starting an output buffer. |
There was a problem hiding this comment.
Present tense or past tense? I'd think the latter is more appropriate (although PHP 8.4.0 has not yet been released):
Suggested change
| Prior to PHP 8.4.0, this flag can be set when starting an output buffer. | |
| Prior to PHP 8.4.0, this flag could be set when starting an output buffer. |
Analogous below.
Girgias
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents the changes made in php/php-src#13087 and php/php-src#15183. Also related to php/php-src#16133.