Skip to content

Ensure annotations work on tests that use dataProviders #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2016
Merged

Ensure annotations work on tests that use dataProviders #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc1e9f6
Ensure annotations work on tests that use dataProviders
alnorth Jun 14, 2016
f1c088b
Tweaks based on code review.
alnorth Oct 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PHPUnit/Util/Log/VCR.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ public function addRiskyTest(PHPUnit_Framework_Test $test, Exception $e, $time)
public function startTest(PHPUnit_Framework_Test $test)
{
$class = get_class($test);
$method = $test->getName();
$method = $test->getName(false);

if (!method_exists($class, $method)) {
return;
Expand Down
19 changes: 19 additions & 0 deletions tests/PHPUnit/Util/Log/VCRTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,23 @@ public function testInterceptsWithAnnotations()
$result = file_get_contents('http://google.com');
$this->assertEquals('This is a annotation test dummy.', $result, 'Call was not intercepted (using annotations).');
}

/**
* @vcr unittest_annotation_test
* @dataProvider aDataProvider
*/
public function testInterceptsWithAnnotationsWhenUsingDataProvider($dummyValue)
{
// Content of tests/fixtures/unittest_annotation_test: "This is a annotation test dummy".
$result = file_get_contents('http://google.com');
$this->assertEquals('This is a annotation test dummy.', $result, 'Call was not intercepted (using annotations with data provider).');
}

public function aDataProvider()
{
return array(
array(1),
array(2)
);
}
}