Default translation with prefix #238
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
requested changes
Jul 3, 2018
| * @return ImportResult | ||
| */ | ||
| public function extractToCatalogues(Finder $finder, array $catalogues, array $config = []) | ||
| public function extractToCatalogues(Finder $finder, array $catalogues, array $config = [], string $prefixTarget = null) |
| @@ -96,6 +98,9 @@ public function extractToCatalogues(Finder $finder, array $catalogues, array $co | |||
| $meta = $this->getMetadata($result, $key, $domain); | |||
| $meta->setState('new'); | |||
| $this->setMetadata($result, $key, $domain, $meta); | |||
| if (null !== $prefixTarget) { | |||
| $this->setTarget($catalogue, $key, $prefixTarget, $domain, $translation); | |||
There was a problem hiding this comment.
It may be a translation in $meta. Do this after the if (null === $translation) block.
| @@ -92,13 +92,14 @@ protected function configure() | |||
| ->addArgument('locale', InputArgument::OPTIONAL, 'The locale ot use. If omitted, we use all configured locales.', false) | |||
| ->addOption('hide-errors', null, InputOption::VALUE_NONE, 'If we should print error or not') | |||
| ->addOption('bundle', 'b', InputOption::VALUE_REQUIRED, 'The bundle you want extract translations from.') | |||
| ->addArgument('prefixTarget', InputArgument::OPTIONAL, 'The prefix of Target', null) | |||
There was a problem hiding this comment.
We should add 2 arguments. One should be prefix and one key-as-translation or something similar.
|
Any progress here? |
|
Friendly ping |
|
@xfifix is there any progress? Your PR looks great, it covers more cases like key-as-translation. Would you rebase it and consider comment? Thanks a lot! |
|
@welcoMattic Sorry, I don't work on the subject and we abandoned this idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<segment> <source>email.logo.title</source> <target>_email.logo.title</target> </segment>