Skip to content

Introduce a type lookup cache for faster en/decoding #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Introduce a type lookup cache for faster en/decoding #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 23 additions & 5 deletions src/Metadata/Collection/TypeCollection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
use IteratorAggregate;
use Soap\Engine\Exception\MetadataException;
use Soap\Engine\Metadata\Model\Type;
use function array_key_exists;
use function Psl\Dict\reindex;

/**
* @implements IteratorAggregate<int<0,max>, Type>
Expand All @@ -20,12 +22,24 @@ final class TypeCollection implements Countable, IteratorAggregate
*/
private array $types;

/**
* @var array<string, Type>
*/
private array $qualifiedLookup;

/**
* @no-named-arguments
*/
public function __construct(Type ...$types)
{
$this->types = $types;
$this->qualifiedLookup = reindex(
$types,
static fn (Type $type): string => self::createLookupKey(
$type->getXsdType()->getName(),
$type->getXsdType()->getXmlNamespace()
)
);
}

/**
Expand Down Expand Up @@ -99,12 +113,16 @@ public function fetchFirstByName(string $name): Type
*/
public function fetchByNameAndXmlNamespace(string $name, string $namespace): Type
{
foreach ($this->types as $type) {
if ($name === $type->getName() && $namespace === $type->getXsdType()->getXmlNamespace()) {
return $type;
}
$lookupKey = self::createLookupKey($name, $namespace);
if (!array_key_exists($lookupKey, $this->qualifiedLookup)) {
throw MetadataException::typeNotFound($name);
}

throw MetadataException::typeNotFound($name);
return $this->qualifiedLookup[$lookupKey];
}

private static function createLookupKey(string $name, string $namespace): string
{
return $namespace . ':' . $name;
}
}