Skip to content

Fix broken PHP80 type #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Fix broken PHP80 type #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/HttpBinding/SoapRequest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ final class SoapRequest
private string $location;
private string $action;
private int $version;
private int $oneWay;
private bool $oneWay;

public function __construct(string $request, string $location, string $action, int $version, int $oneWay = 0)
public function __construct(string $request, string $location, string $action, int $version, bool $oneWay = false)
{
$this->request = $request;
$this->location = $location;
Expand Down Expand Up @@ -52,7 +52,7 @@ public function isSOAP12(): bool
return $this->getVersion() === self::SOAP_1_2;
}

public function getOneWay(): int
public function getOneWay(): bool
{
return $this->oneWay;
}
Expand Down
4 changes: 2 additions & 2 deletions tests/Unit/HttpBinding/SoapRequestTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ final class SoapRequestTest extends TestCase
{
public function test_request()
{
$request = new SoapRequest('requestbody', 'location', 'action', SoapRequest::SOAP_1_1, 0);
$request = new SoapRequest('requestbody', 'location', 'action', SoapRequest::SOAP_1_1, false);

static::assertSame('requestbody', $request->getRequest());
static::assertSame('location', $request->getLocation());
static::assertSame('action', $request->getAction());
static::assertSame(SoapRequest::SOAP_1_1, $request->getVersion());
static::assertSame(0, $request->getOneWay());
static::assertSame(false, $request->getOneWay());
}
}