Fix SF 4.3 deprecation with Dotenv #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing tests are fixed in another PR #159 |
|
CI is failing, looks like php-pm/php-pm#457? I‘ll try to enable scheduled builds to catch these failures earlier. |
|
@andig yes exactly, this is hard to see if we don't build in a regular basis. I saw it when we updated our project to SF 4.3 |
|
I‘ve added monthly builds for the time beeing and will release asap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since SF 4.3, the
Dotenvcomponent now explicitly requires that we enable the use ofputenv()calls. Since we usegetenv()later on the bootstrap, the property needs to betrue.