Fix: Recreate disconnected connections when being retrieved #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the problem described in #18 where manually closing a connection will not remove the connection from the
ConnectionManager
:As a solution to this problem, we simply reinitialize the connection on retrieval. Another option would be to reconnect using the old instance, but this approach will always yield a fresh instance.
Known issues:
$mqtt->isConnected()
will not detect connection loss based on closed sockets, socket timeouts and similar. To do so, we would need to ping the MQTT broker, which is currently not easily possible due to the way data is sent and received. Imagine the following scenario: