Replace obsolete macros AC_TRY_FOO with AC_FOO_IFELSE #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petk
changed the title
|
Redacted: I've now replaced all obsolete See commit message for more info... |
sodabrew
requested changes
Jul 20, 2018
config.m4
Outdated
| [ ac_cv_memc_sasl_support="yes" ], | ||
| [ ac_cv_memc_sasl_support="no" ] | ||
| ) | ||
| ]])],[ac_cv_memc_sasl_support="yes"],[ac_cv_memc_sasl_support="no"]) |
There was a problem hiding this comment.
Nit: keep the same line split.
config.m4
Outdated
| AC_TRY_COMPILE( | ||
| [ #include <libmemcachedprotocol-0.0/handler.h> ], | ||
| [ memcached_binary_protocol_callback_st s_test_impl; | ||
| AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <libmemcachedprotocol-0.0/handler.h>]], [[memcached_binary_protocol_callback_st s_test_impl; |
config.m4
Outdated
| [ ac_cv_have_libmemcachedprotocol="yes" ], | ||
| [ ac_cv_have_libmemcachedprotocol="no" ] | ||
| ) | ||
| ]])],[ac_cv_have_libmemcachedprotocol="yes"],[ac_cv_have_libmemcachedprotocol="no"]) |
Autoconf made several macros obsolete including the AC_TRY_COMPILE and AC_TRY_LINK in 2000 and since Autoconf 2.50: http://git.savannah.gnu.org/cgit/autoconf.git/tree/ChangeLog.2 These macros should be replaced with the current AC_FOO_IFELSE instead. It is fairly safe to upgrade and take the recommendation advice of autoconf upgrade manual since the upgrade should be compatible at least with PHP versions 5.4 and up, on some systems even with PHP 5.3. PHP versions from 5.4 to 7.1 require Autoconf 2.59+ and PHP 7.2+ require Autoconf 2.64+. This patch was created with the help of autoupdate script. Reference docs: - https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Obsolete-Macros.html - https://www.gnu.org/software/autoconf/manual/autoconf-2.59/autoconf.pdf
|
Longer lines have been split as suggested. Yes, I'm not much familiar with any coding style for the M4 files, so feel free to refactor or suggest if there is something missing here. This is mostly done as autoupdate has done it automatically and what is in the manual... |
sodabrew
approved these changes
Sep 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, Autoconf made several macros obsolete in several versions behind very long time ago, including the
AC_TRY_COMPILEwhich should be replaced with currentAC_COMPILE_IFELSEinstead.Refs:
This patch has been done with the help of
autoupdatescript:Thanks for considering checking this out or merging it.