Skip to content

Conversation

@ddeboer
Copy link
Contributor

@ddeboer ddeboer commented Jan 10, 2022

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets
Documentation
License MIT

What's in this PR?

  • Support Symfony 6.
  • Remove EOL PHP and Symfony versions.
  • Upgrade PHPStan.

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
  • Documentation pull request created (if not simply a bugfix)

To Do

  • If the PR is not complete but you want to discuss the approach, list what remains to be done here

@ddeboer ddeboer force-pushed the symfony-6 branch 2 times, most recently from 17397f9 to d6c8b75 Compare January 10, 2022 11:35
@ddeboer
Copy link
Contributor Author

ddeboer commented Jan 10, 2022

This should work, but I’m not seeing the Travis or Scrutinizer checks here. Why not?

@dbu
Copy link
Contributor

dbu commented Jan 10, 2022

travis builds stopped working with the changes they did. we migrated repositories to github actions, but aparently not on this repository. would you have time to rewrite the .travis.yml to a github-action workflow? similar to https://github.com/php-http/client-common/blob/master/.github/workflows/tests.yml

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for looking into this. a few remarks:

@dbu
Copy link
Contributor

dbu commented Jan 12, 2022

can you rebase on master please, and do the change on the github action instead of travis.yml?

@ddeboer ddeboer force-pushed the symfony-6 branch 2 times, most recently from 9bdce79 to 099ed10 Compare January 12, 2022 13:54
* Remove EOL PHP and Symfony versions.
* Upgrade PHPStan.
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@dbu dbu merged commit da3fcc2 into php-http:master Jan 12, 2022
@ddeboer ddeboer deleted the symfony-6 branch January 12, 2022 13:56
@dbu
Copy link
Contributor

dbu commented Jan 12, 2022

tagged as https://github.com/php-http/vcr-plugin/releases/tag/1.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants