Skip to content

Allow PHP 8 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 30, 2020
Merged

Allow PHP 8 #13

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e13a21
Allow PHP 8
ddeboer Nov 27, 2020
04a4410
Try 8.0snapshot
ddeboer Nov 27, 2020
c35e4d8
Remove php-cs-fixer, which is incompatible with PHP 8
ddeboer Nov 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ php:
- 7.2
- 7.3
- 7.4
- 8.0snapshot
Copy link

@veewee veewee Nov 27, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Php-cs-fixer does not suppor PHP8 yet, but you can run composer with --ignore-platform-req=php

And add this env var to run php-cs-fixer:

PHP_CS_FIXER_IGNORE_ENV: 1

Copy link
Contributor Author

@ddeboer ddeboer Nov 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the dep for now, as suggested by @Nyholm.


env:
global:
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
}
],
"require": {
"php": "^7.2",
"php": "^7.2 || ^8.0",
"guzzlehttp/psr7": "^1.7",
"php-http/client-common": "^2.0",
"psr/log": "^1.1",
Expand Down