This repository was archived by the owner on Jan 16, 2018. It is now read-only.
expose underlying HttpClient methods in HttpMethodsClient #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/HttpMethodsClient.php
Outdated
Contributor
Author
There was a problem hiding this comment.
i guess we should do this, in case somebody extends the methods-client to add something on sendRequest
Member
|
Why is the |
Member
|
👍 |
Contributor
Author
|
i did not change that. hm, but good question. the use case would be custom HTTP methods? probably makes sense, will change that. i ran the tests locally. can we enable travis for this repo? the .travis.yml file is present already. |
dbu
force-pushed
the
expose-underlying-client
branch
from
281b70c to
30a166a
Compare
Member
|
I know you didn't change that, just spotted it now. Custom HTTP methods, GET requests with body. Travis enabled. |
Contributor
Author
|
made send public. now we also have a way to GET with a body without using the message factory. exposing the underlying HttpClient still makes sense. |
Member
|
👍 |
dbu
added a commit
that referenced
this pull request
Oct 23, 2015
expose underlying HttpClient methods in HttpMethodsClient
Contributor
Author
|
ups, i will try to fix the build.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7