User and implementor stuff separation

[dbu]

We discussed the role of php-http/utils versus php-http/helper. One idea was to separate things that HTTP client users would need versus HTTP client providers.

BatchRequest and BatchResponse are only relevant for implementors, not for users of a client. The users have to use the BatchResponse interface, and the BatchRequest trait is only relevant for adapters for non-parallel clients. Imho we should move those to helper (and maybe think of a better name for that repository, like client-implementation-helper)

[sagikazarmark]

Yeah, probably this point of view makes the most sense. Even if the logic of package organization might not be clear for everyone at first, it is easy to understand, so let's follow this.

Client-helper maybe?

[joelwurtz]

More than implementation-helper or integration-helper (like the adapter-integration-test package name)

(Client helper is confusing IMO)

[joelwurtz]

It can be closed i think, as all classes here now are user utilities.

[dbu]

right, thanks!

[sagikazarmark]

Reopening this as I think there is room for some more separation here. PR is on the way, after that we can decide about any further separation.

[dbu]

i think the Batch stuff we talked about is now fine here in utils, as there is no more interface. but if there are other implementor-only things i agree to separate them.

[sagikazarmark]

Yeah, that's why I changed the title.

I think that partly the Fulfilled/Rejected Promise thing can also be partly implementor things, but I am in the middle of planning.

In the meantime: naming question is still open. Utils? How should we call the two packages?

[dbu]

i think utils is a good name for user utilities. the other could be implementor-tools maybe?

[sagikazarmark]

From the purpose of point of view, it is a good name.

From a domain point of view, it is not really.

[sagikazarmark]

Pushed changes in the implementation_separation branch.

I would use these tools for example in the guzzle6 adapter where the sync behavior is currently emulated.