Allow PHP 8 #16
Allow PHP 8 #16
Conversation
"Arrays MUST use the short syntax." https://docs.styleci.io/fixers#short_array_syntax
dbu
left a comment
dbu
left a comment
There was a problem hiding this comment.
thanks for looking into this
"CodeCoverage should not be used with spec testing in order to see how good your tests are." https://github.com/henrikbjorn/PhpSpecCodeCoverageExtension
| - php: 7.1 | ||
| - php: 7.2 | ||
| - php: 7.3 | ||
| env: COVERAGE=true TEST_COMMAND="composer test-ci" DEPENDENCIES="henrikbjorn/phpspec-code-coverage:^1.0" |
There was a problem hiding this comment.
This may need some discussion, but this dependency is deprecated so I decided to remove code coverage.
dbu
left a comment
dbu
left a comment
There was a problem hiding this comment.
thanks.
i strongly disagree with nikolas on that one. its trivial to open a new major php version when it comes along, if there are no BC breaks affecting the library. if there are BC breaks, its a pain for users to figure out if they will have a problem when they use dependencies that don't properly declare what they are tested with. i keep closing issues on our guzzle6-adapter from people asking to support php 8, when guzzle 6 itself has failing tests on php 8 (but uses the >= 5.5 constraint [note how guzzle 7 properly declares php versions it is compatible with])
2 participants
What's in this PR?
Support PHP 8.0.