Improve tests

[gmponos]

Q	A
Bug fix?	yes
New feature?	yes
BC breaks?	no
Deprecations?	no
License	MIT

What's in this PR?

• Use assertSame where it had meaning.
• Use a clone of the objects under testing. This way we ensure that the object has not changed state.
• Added some more assertions.

To Do

• Need to check more places about using assertEqual with a clone.

[gmponos]

I think that's it.. hope I haven't missed anything but if I did we can do more improvements later.

[gmponos]

I also added more invalid cases of METHOD... see

[dbu]

i like the changes to assertSame and additional type checks.

i am not sure i fully get what the getClone method is supposed to do - i think it would be cleaner to explicitly clone the original request/response in 1-2 places where we test that indeed the original object is not altered, instead of having a clone method and that many checks? the getCone method name is also very generic and not explaining what it is for.

[gmponos]

i am not sure i fully get what the getClone method is supposed to do

The abstract definition of getClone method is there in order for the trait to ensure that the method exists and be able to be used by the trait tests.. check this

i think it would be cleaner to explicitly clone the original request/response in 1-2 places

Yes I can clone the message per test case... but the places I counted are 5 not 1-2 😄 .. I have no disagreement about this.. I will make the changes...

the getCone method name is also very generic

I was pretty sure about this comment.. I have the same feeling as you... Since I will remove it and do the clone per test case then no need to think of a name.. if you change your mind and keep it I vote for getMessageOriginalState

[dbu]

okay, cool! when i said 1-2 places i was thinking if we need the clone in all places we currently use it. if there is a specific reason to test that in each of the places, i am all for it, but we should not test the same thing multiple times.

[dbu]

i find it more readable this way with the clone in the tests. thanks!