Fix fatal error for long bodies #116
Conversation
dbu
left a comment
dbu
left a comment
There was a problem hiding this comment.
thanks for looking into this!
i wonder if it even makes sense to output more than 8K of body - it will be hard to copy-paste and might explode things like the symfony debug panel. i feel that people would want to log larger bodies to some file if they need to debug something. maybe lets just limit to 8192 and say that this should work on all operating systems. wdyt?
Totally agree, it's neither user friendly nor memory friendly |
dbu
left a comment
dbu
left a comment
There was a problem hiding this comment.
looks good to me. suggestion to tweak the commend. @php-http/httplug do you agree with this change or do you see any issue?
|
thanks! |
|
released 1.8.0 with this and some other fixes. |
* Fix fatal error for long bodies * Set body size limit to 8192 * Phrasing
2 participants
What's in this PR?
Prevent
CurlCommandFormatterto throw a Fatal exception when body size exceedescapeshellargargument allowed length. Didn't find a great way to get the limit tho... Windows limit come from PHP source code, the UNIX fromIf you have a better solution to find
escapeshellarglimit, I'm all earsChecklist