Illuminate manager

[dlnilsson]

This is a common approach in Laravel echo system, using the manager class with a facade to handle multiple drivers (clients).

However we could leverage the factory classes used in the symfony bundle to instantiate the clients if we move them to a third package.

[Nyholm]

Thank you for this PR.
Im +1 for moving factories to a third package (new or existing). Those have nothing todo with Symfony.

I think the tests are failing because we miss the ´phpunit.xml.dist`.

Btw, does this allow us to have two Guzzle6 clients with different set of plugins?

[dlnilsson]

Btw, does this allow us to have two Guzzle6 clients with different set of plugins?

Yes, well you could do something like:

<?php
// place this in a new serviceprovider or extend HttplugServiceprover
$manager->extend('guzzle6-plugins', function () {
        // add custom configuration, plugins etc..
        return new \Http\Adapter\Guzzle6\Client();
});

[welcoMattic]

Really cool work! Thank you for it. Actually I thought that I had time to work on it, but things are not happen as we will wish 😉

[sagikazarmark]

@Nyholm can you manage this? I have exactly 0 experience with Laravel.

[sagikazarmark]

BTW thanks for the work on this.

[Nyholm]

Let's use the configured factory:

$factory = app()->make('httplug.message_factory.default');
$request = $factory->createRequest('GET', 'http://httpbin.org');

[Nyholm]

I do not have a lot of experience with Laravel either. That's why @danijeel reached out and offered to help.

I've made some comments. Do 👍 or update the readme if they are okey and I'll be happy to merge this PR.

Thank you!

[sagikazarmark]

@GrahamCampbell you might also be interested in this

[Nyholm]

Thank you again @danijeel