document cache plugin #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Cache Control Handling | ||
| ---------------------- | ||
|
|
||
| This plugin does not cache responses with ``no-store`` or ``private`` instructions. |
Contributor
Author
There was a problem hiding this comment.
feel like we should also respect no-cache. php-http/plugins#58
dbu
force-pushed
the
cache-plugin
branch
2 times, most recently
from
382c71e to
27e8d39
Compare
plugins/cache.rst
Outdated
| The ``CachePlugin`` allows you to cache responses from the server. It can use | ||
| any PSR-6 compatible caching engine. By default, the plugin respects the cache | ||
| control headers from the server as specified in :rfc:`7234`. It needs a | ||
| :ref:`stream <message-factory>` and a `PSR-6`_ implementation:: |
Contributor
Author
There was a problem hiding this comment.
needs to be adjusted once #87 is merged, or the other way round.
Contributor
Author
|
this is imho ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #41