Skip to content

Conversation

dbu
Copy link
Contributor

@dbu dbu commented Apr 28, 2023

merge #304 with the changes i did in #305

@dbu dbu merged commit fc63080 into master Apr 28, 2023
Copy link
Contributor

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking care of this, here are some minor things

offer zero-configuration services relying on the virtual packages.

Using discovery in a shared library
-------------------------------------
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra dashes

$ composer require --dev symfony/http-client
$ composer require --dev nyholm/psr7
Then, you can disable the Composer plugin provided by``php-http/discovery``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space after "by"

@dbu dbu deleted the discovery branch April 28, 2023 13:21
@dbu
Copy link
Contributor Author

dbu commented Apr 28, 2023

thanks for the review. i was too quick merging this 🙈

fixed them directly in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants