Added small script to test installation on with different dependencies #157
Conversation
dbu
left a comment
dbu
left a comment
There was a problem hiding this comment.
thanks, good idea!
can we improve output of the build? its rather cryptic now to see what is not working. and do you plan on adding the fix in this PR too?
| echo -e "\\e[41mKO\\e[0m $title\\n" | ||
| (exit $ok) | ||
| } | ||
| export -f install_test |
There was a problem hiding this comment.
could we add this as a bash file to tests folder, or .travis folder? no big deal, but it seems a bit much for the travis configuration file
There was a problem hiding this comment.
I dont think so. Im not sure how you can "export" a function in bash/travis.
There was a problem hiding this comment.
ah i see, bash function, not bash script. i guess thats fine then. maybe bash source-ing the file would work, but i will merge as is and tag another patch release
|
Sure, I added a commit with a fix for #156 |
What do you suggest?
|
|
i somehow expected something before the error line, but the last line is enough. as it should normally not fail, it will at least indicate when something is amiss. |
|
Thank you for merging |
2 participants
This is a small script to make sure we test different sets of configuration. Related to #156
Test should fail because #156 describes a problem.