add missing type declarations #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
commented
Jan 2, 2019
dbu
commented
Jan 2, 2019
GrahamCampbell
suggested changes
Jan 2, 2019
| * @throws TransferException | ||
| */ | ||
| private function createCookie(RequestInterface $request, $setCookie) | ||
| private function createCookie(RequestInterface $request, string $setCookieHeader) |
Contributor
There was a problem hiding this comment.
I guess we'd need PHP 7.1 for that. Is there any reason why 2.x is php 7.0+ and not 7.1+. 7.0 is EOL already.
Contributor
Author
There was a problem hiding this comment.
thats why i did not do it. but i wondered the same. happy to move to 7.1+. wdyt @Nyholm ?
Contributor
Author
There was a problem hiding this comment.
cool! however, i'd prefer to do that in a separate pull request, as it will entail quite a lot of changes.
Contributor
Author
|
okay if i merge this and continue in a new PR to upgrade to php 7.1? |
Member
|
Yes, go ahead. |
Closed
Member
|
I added #148 about dropping PHP 7.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Went over the code again to find places where we can add type hints.