Support PSR-18 #135
Merged
Support PSR-18 #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Thank you for the review |
dbu
approved these changes
Dec 29, 2018
Contributor
dbu
left a comment
dbu
left a comment
There was a problem hiding this comment.
very nice. great that the psr turned out to be compatible 👍
src/FlexibleHttpClient.php
Outdated
| { | ||
| if (!($client instanceof HttpClient) && !($client instanceof HttpAsyncClient)) { | ||
| if (!($client instanceof ClientInterface) && !($client instanceof HttpAsyncClient)) { | ||
| throw new \LogicException('Client must be an instance of Http\\Client\\HttpClient or Http\\Client\\HttpAsyncClient'); |
Contributor
There was a problem hiding this comment.
we should adjust the exception message too
src/Plugin/AddPathPlugin.php
Outdated
| $request = $request->withUri($request->getUri() | ||
| $request = $request->withUri( | ||
| $request->getUri() | ||
| ->withPath($this->uri->getPath().$request->getUri()->getPath()) |
Contributor
There was a problem hiding this comment.
not sure that this is more readable than the previous formatting. should we indent this some more? or extract the argument on this line to a variable so we can put $request->getUri()->withPath($prefixedPath) on one line?
Member
Author
There was a problem hiding this comment.
this change must have been suggested/automatic.
I like your suggestion though.
dbu
approved these changes
Dec 29, 2018
Member
Author
|
This will fix #122 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
We should show that we support PSR-18. I've replaced
Http\Client\HttpClientwithPsr\Http\Client\ClientInterfaceon all the places where we consume a client.This will fix #122