Skip to content

Conversation

@Jean85
Copy link
Contributor

@Jean85 Jean85 commented Nov 19, 2018

Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Related tickets partially #115
License MIT

What's in this PR?

This PR drops the only deprecation present in 1.x branch.

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
  • Documentation pull request created (not needed)

@dbu dbu merged commit 1adbf74 into php-http:2.x Nov 19, 2018
@dbu
Copy link
Contributor

dbu commented Nov 19, 2018

thank you!

@Jean85 Jean85 deleted the remove-deprecations branch November 19, 2018 10:54
@Jean85
Copy link
Contributor Author

Jean85 commented Nov 19, 2018

Can you add the 2.0 milestone here?

@sagikazarmark sagikazarmark added this to the v2.0.0 milestone Nov 19, 2018
@sagikazarmark
Copy link
Member

Done

@rtripault
Copy link

rtripault commented Nov 20, 2018

I believe you also might want to remove anything related to debug_plugins option in PluginClient::createPluginChain

@dbu
Copy link
Contributor

dbu commented Nov 20, 2018

indeed. @Jean85 would you mind doing another pull request to remove all mentions of debug_plugins in this file? and can you check the rest of the repository if its mentioned anywhere else, like in the documentation?

@Jean85
Copy link
Contributor Author

Jean85 commented Nov 20, 2018

@dbu completed in #119; no other mention of it in the whole project, apart from the changelog.

@dbu
Copy link
Contributor

dbu commented Nov 20, 2018

thanks! yeah we want to keep the changelog ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants