Do not use defer #111
Merged
Do not use defer #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Unfortunately i have very little time ATM to deal with the Defer problem :s, so yes, if nobody came up with a solution reverting it is better ATM and will try to tackle the problem latter |
dbu
approved these changes
Sep 30, 2018
Contributor
dbu
left a comment
dbu
left a comment
There was a problem hiding this comment.
okay, better inefficient than wrong. can you add some note in the documentation that using the retry plugin kills async? and open an issue in this repo to implement retry async correctly?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I revert the changes to RetryPlugin as a temporary fix for #109. Only consider this if we cannot properly fix it (as attempted in #110)