Cast max age to integer #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!is_bool($maxAge)) { | ||
| $ageHeaders = $response->getHeader('Age'); | ||
| foreach ($ageHeaders as $age) { | ||
| return $maxAge - ((int) $age); |
Contributor
There was a problem hiding this comment.
this will cast to int automatically, right?
Contributor
|
thanks! makes sense to me. should we add a note to the changelog for this? |
Member
|
@egeloen can you please add some changelog for this? ## UNRELEASED
### Fixed
- Integer casting something ... |
Author
|
@sagikazarmark Done |
Contributor
|
thanks a lot! i merged, the styleci error is not related to this PR. |
This was referenced Aug 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
What's in this PR?
This PR fixes an issue in the max age calculation. Basically, the PSR-7 implementations returns a string as header value whereas the max age should be an integer.
Why?
Since PHP is able to implicitely convert string to integer on the fly, it should not be an issue but when using with a PSR-6 provider such the Symfony one, adapters requires an integer as ttl otherwise it throws an exception (see here fox example).