chore: Add ClientInterface return typehint for php-http/httplug >= 2.4 #435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
approved these changes
Aug 31, 2023
Collaborator
dbu
left a comment
dbu
left a comment
There was a problem hiding this comment.
correct. actually with httplug 2, the httplug HttpClient interface extends the psr ClientInterface, but if somebody relies on still getting an old httplug instance the old annotation still makes sense.
Collaborator
Collaborator
|
thanks a lot for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Add ClientInterface return typehint for php-http/httplug >= 2.4
Why?
Return type of method ClientFactory::createClient() has typehint with deprecated interface Http\Client\HttpClient:
since version 2.4, use Psr\Http\Client\ClientInterface instead