Use ClientInterface in MockFactory #430
Conversation
HttpClient is deprecated in favor of ClientInterface. By accepting ClientInterface in the MockFactory, developers can transition to the ClientInterface.
|
@dbu is this the way to do it? |
dbu
left a comment
dbu
left a comment
There was a problem hiding this comment.
thanks. this should be BC because the httplug client implements the psr interface.
|
What about the failing test? Do I need to fix more? |
|
it mentions buzz. is that the problem? the buzz adapter is quite outdated and i want to deprecate it. can you try to raise the minimum requirement on php-http/httplug ? if i understand the problem correctly, we can then no longer install with buzz-adapter (because that is pulling us down to such a low version of httplug that we don't implement the psr interface yet). we should raise that minimum requirement anyways to avoid invalid situations (check what version has httplug client interface start extend the psr interface). if this is indeed the problem, i suggest we remove buzz from that matrix entry (or if thats the only difference to other builds just remove the whole matrix entry) |
It's not compatible with HTTPlug 2.0
|
@dbu done, raised version and removed buzz-adapter from the matrix. |
| php-version: "8.2" | ||
| symfony-deprecations-helper: "weak" | ||
|
|
||
| # Test with httplug 1.x clients |
There was a problem hiding this comment.
ah, httplug 1 was the problem in general. agree to drop that.
2 participants
What's in this PR?
HttpClient is deprecated in favor of ClientInterface. By accepting ClientInterface in the MockFactory, developers can transition to the ClientInterface.