Added an sf4 example for enabling the bundle #376
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
thanks. this is better than explaining the symfony 3 way. we have https://php-http.readthedocs.io/en/latest/integrations/symfony-bundle.html which seems like the right external source. can you change the readme to only explain the flex way, and link to the documentation for the installation without flex? and do this PR against the documentation to explain the symfony 4/5 way of things? |
Collaborator
|
see #380 and php-http/documentation#275 |
Collaborator
|
thanks for bringing this up @gmponos |
Contributor
Author
|
arggg.. my mind always forgets things like documentations and stuff.. totally forgot to update this PR. Anyway glad it helped in anyway... |
Collaborator
|
no worries, was quick to wrap it up, thanks for having realized it in the first place! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Update the README file on how to register/enable the bundle.
TBH it might be preferable to point to an external resource.