Skip to content

Update http_message.html.twig #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2019
Merged

Update http_message.html.twig #368

merged 1 commit into from
Dec 10, 2019

Conversation

@dbu
Copy link
Collaborator

@dbu dbu commented Dec 10, 2019

fix minor bug with #366 so that we actually match https links

@dbu dbu mentioned this pull request Dec 10, 2019
Merged
@ostrolucky
Copy link
Collaborator

ostrolucky commented Dec 10, 2019

Yeah this is all we need, but perhaps we don't even need regex group, but that's minor

@dbu
Copy link
Collaborator Author

dbu commented Dec 10, 2019

yep thanks, you are right the () is not necessary, checked with a regex checker to be sure ;-)

@dbu dbu merged commit 0398c04 into master Dec 10, 2019
@dbu dbu deleted the fix-https-regex branch December 10, 2019 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dbu @ostrolucky