Test on PHP74 #364
Closed
Test on PHP74 #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
reviewed
Nov 28, 2019
Collaborator
dbu
left a comment
dbu
left a comment
There was a problem hiding this comment.
Narrators voice: "But they have not" :-(
Lets wait a bit, i'd hope they are on it.
Collaborator
|
@Nyholm oh look, it works, and no bad surprises. can you adjust the .travis.yml thing? |
Collaborator
|
hm, why does coverage time out with 7.4? maybe we should run the coverage build with 7.3 after all - i guess its very unlikely that this is an issue in our code. |
Collaborator
|
the dev build should also use 7.4 btw |
Collaborator
|
fixed in #369 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see if Travis has updated their list of runtimes =)