Skip to content

don't call getResponse() on RequestExceptionInterface #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2019
Merged

don't call getResponse() on RequestExceptionInterface #305

merged 1 commit into from
Jan 20, 2019

Conversation

@xabbuh
Copy link
Member

@xabbuh xabbuh commented Jan 17, 2019

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #304
Documentation
License MIT

dbu
dbu approved these changes Jan 17, 2019
View reviewed changes
Copy link
Collaborator

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! please fix the cs issue (i guess RequestExceptionInterface is no longer used in those classes)

Nyholm
Nyholm approved these changes Jan 20, 2019
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Nyholm Nyholm merged commit f718e56 into php-http:master Jan 20, 2019
@xabbuh xabbuh deleted the issue-304 branch January 20, 2019 10:33
This was referenced Mar 13, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbu dbu dbu approved these changes

@Nyholm Nyholm Nyholm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Undefined method getResponse() being called on RequestExceptionInterface

3 participants

@xabbuh @dbu @Nyholm