Allow you to configure a client without a factory #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
approved these changes
Mar 27, 2018
Collaborator
dbu
left a comment
dbu
left a comment
There was a problem hiding this comment.
very good point, and i love how straightforward this looks. big +1
can you please add something to the changelog and do a PR against the documentation repository as well?
| ->end() | ||
| ->scalarNode('service') | ||
| ->defaultNull() | ||
| ->info('The service id of for the client to use.') |
dbu
approved these changes
Mar 27, 2018
Member
Author
|
Thank you for the review. I updated it accordingly and added a PR to the docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
The current way to define clients is:
However, If you already have a service you should be able to just "link" that.
This will allow you do decorate your custom HTTPlug clients with plugins and other nice things.