Make main aliases public #254
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Symfony 3.4+ is making services private by default, so this requires configuring the visibility explicitly.
dbu
approved these changes
Feb 20, 2018
Collaborator
dbu
left a comment
dbu
left a comment
There was a problem hiding this comment.
agreed! and thanks for the fix stof
Contributor
Author
|
what about non-default clients ? |
Collaborator
|
the should be injected in DI. but i am not opposed to make the client services public. |
Contributor
Author
|
well, if you consider that using DI for other clients is better, that's fine with me (I don't have a use case for that need anyway as I have only 1 client currently) |
Collaborator
|
i guess if you have multiple clients configured, you would want to inject them and not pull. if there is a use case for it, i am not opposed to a pull request however. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Symfony 3.4+ is making services private by default, so this requires configuring the visibility explicitly.
Why?
This allows keeping
$this->get('httplug.client')working without deprecation.For now, I haven't applied this change to the different client services, but it might make sense as well.