Make sure we use different cache directories every time we run the tests #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
reviewed
Sep 3, 2017
Collaborator
dbu
left a comment
dbu
left a comment
There was a problem hiding this comment.
i agree for the sake of clean tests, but our code should be robust to not fail on outdated format or even corrupt files.
|
|
||
| /** | ||
| * @var string | ||
| */ |
Collaborator
There was a problem hiding this comment.
nitpick: this is not just the prefix but the whole folder name
Contributor
|
StyleCI errors are fixed in #203. |
Member
Author
|
The PR is updated and ready to be merged. |
fbourigault
approved these changes
Sep 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
When you run the tests you build some cache in your system's temp directory. If you say, bump some versions that cache may not be properly cleared. This fix make sure we always start with a clear cache every time we run the tests.