Allow you to skip the factory keyword. #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
May 21, 2017
| ->ifTrue(function ($config) { | ||
| return $config['factory'] === 'httplug.factory.auto' && !empty($config['config']); | ||
| }) | ||
| ->thenInvalid('You must specify a valid "factory" in order to use the "config"') |
Member
There was a problem hiding this comment.
IMO this message is not really clear. What does "valid config" mean in this context?
Member
Author
There was a problem hiding this comment.
Thank you. Is it better now?
fbourigault
reviewed
May 21, 2017
| */ | ||
| public function createClient(array $config = []) | ||
| { | ||
| return HttpClientDiscovery::find(); |
Contributor
There was a problem hiding this comment.
Does it worth to fallback to HttpAsyncClientDiscovery if HttpClientDiscovery does not returned any implementation?
Member
Author
There was a problem hiding this comment.
I doubt it. I believe it is very rare that an async adapter/client does not implement HttpClient interface (not async).
fbourigault
approved these changes
May 22, 2017
Member
Author
|
Thank you for the reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #168