show profiler badges in the toolbar and the menu #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
approved these changes
Feb 21, 2017
sagikazarmark
approved these changes
Feb 21, 2017
Member
|
LGTM |
Nyholm
approved these changes
Feb 21, 2017
Member
Nyholm
left a comment
Nyholm
left a comment
There was a problem hiding this comment.
Excellent PR. Thank you for the images.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add profiler badges introduced with Symfony 2.8 profiler redesign.
The toolbar icon is now displayed wit ha red background if there was errors.
The toolbar hover add squared badges to display numbers.
The failed request count badge is show using red background if a request failed.
The profiler menu show the failed request count
