Skip to content

"append" (true|false) for map & object #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 14, 2023
Merged

Conversation

clemzarch
Copy link
Contributor

        - fastmap:
            expression_language:
              - Kiboko\Component\ArrayExpressionLanguage\ArrayExpressionLanguageProvider
+            append: true
            map:
               # ...
- $output = (function ($input) {
+ $output = (function ($input) use($output) {
-    $output = [];
    $output['sku'] = (function () use($input) {
        ....
    })();
    return $output;
})($input);
return $output;

@clemzarch clemzarch added the GTM Good to merge label May 25, 2023
@clemzarch clemzarch requested review from gplanchat and sebprt May 25, 2023 13:50
@clemzarch clemzarch self-assigned this May 25, 2023
@clemzarch clemzarch added WIP Work in Progress and removed GTM Good to merge labels May 25, 2023
@clemzarch clemzarch force-pushed the feature/output-mode branch 2 times, most recently from ac6d764 to 8be17db Compare May 26, 2023 10:11
@clemzarch clemzarch changed the title append option for map & object "append" (true|false) for map & object May 26, 2023
@clemzarch clemzarch force-pushed the feature/output-mode branch 3 times, most recently from cecaacc to 43c5e2f Compare May 30, 2023 09:34
@clemzarch clemzarch force-pushed the feature/output-mode branch 2 times, most recently from 394388f to 3e67c74 Compare June 8, 2023 10:04
@clemzarch clemzarch requested a review from gplanchat June 8, 2023 10:05
@clemzarch clemzarch force-pushed the feature/output-mode branch from 3e67c74 to 603e269 Compare June 8, 2023 10:11
@clemzarch clemzarch force-pushed the feature/output-mode branch from 603e269 to afa93f7 Compare June 8, 2023 10:14
@clemzarch clemzarch added GTM Good to merge and removed WIP Work in Progress labels Jun 8, 2023
@clemzarch clemzarch force-pushed the feature/output-mode branch from 07fcaee to a5b0187 Compare June 14, 2023 15:16
@clemzarch clemzarch merged commit 475bc14 into main Jun 14, 2023
@clemzarch clemzarch deleted the feature/output-mode branch June 14, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GTM Good to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants