Skip to content

Make sure to copy use_tagging. #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 26, 2016
Merged

Make sure to copy use_tagging. #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3949c86
Make sure to copy use_tagging.
Nyholm Jan 26, 2016
0cf686c
style fix
Nyholm Jan 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Command/CacheFlushCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ protected function configure()
$this->setDescription('Flushes the given cache');
$this->addArgument('type', InputArgument::OPTIONAL, sprintf('Which type of cache do you want to clear? Valid types are: %s', implode(', ', self::VALID_TYPES)));
$this->addArgument('service', InputArgument::OPTIONAL, 'If using type "provider" you must give a service id for the cache you want to clear.');
$this->setHelp(<<<EOD
$this->setHelp(<<<'EOD'
Copy link
Member

@cryptiklemur cryptiklemur Jan 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is correct?

Copy link
Member Author

@Nyholm Nyholm Jan 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is from styleCI. It surprised me too.

Copy link
Member Author

@Nyholm Nyholm Jan 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://styleci.io/analyses/qx0gry

Copy link
Member

@cryptiklemur cryptiklemur Jan 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird...


Types and their description
all Clear all types of caches
Expand Down
3 changes: 3 additions & 0 deletions src/DependencyInjection/Compiler/DoctrineCompilerPass.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@ protected function enableDoctrineSupport(array $config)
continue;
}

// Copy the tagging setting to the $typeConfig
$typeConfig['use_tagging'] = $config['use_tagging'];

// Doctrine can't talk to a PSR-6 cache, so we need a bridge
$bridgeServiceId = sprintf('cache.service.doctrine.%s.%s.bridge', $cacheType, $type);
$this->container->register($bridgeServiceId, DoctrineCacheBridge::class)
Expand Down