Eliminate need for GET_TASKS permission #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Don't check if we are in the foreground - that happens anyway in the sendExtras() method (https://github.com/phonegap-build/PushPlugin/blob/master/src/android/com/plugin/gcm/PushPlugin.java#L111) * Only display a message if the message has text to be displayed Fixes phonegap-build#52 and undoes phonegap-build#3
bobeasterday
added a commit
that referenced
this pull request
Sep 26, 2013
Eliminate need for GET_TASKS permission
|
Nice! |
|
This is what prevents notifications being received when the app is closed. As we don't have get tasks anymore |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PushPlugin.sendExtras() method
Fixes #52 and undoes #3
This might not be a perfect fix, but it seems to work for our application. If anyone has any comments on how to improve before it gets merged, I'd love to improve it.