Skip to content

fix torch version comparison #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix torch version comparison #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
class TestTorchVersionAtLeast(unittest.TestCase):
def test_torch_version_at_least(self):
test_cases = [
("2.5.0a0+git9f17037", "2.5.0", True),
("2.5.0a0+git9f17037", "2.5.0", False),
("2.5.0a0+git9f17037", "2.4.0", True),
("2.5.0.dev20240708+cu121", "2.5.0", True),
("2.5.0.dev20240708+cu121", "2.5.0", False),
("2.5.0.dev20240708+cu121", "2.4.0", True),
("2.5.0", "2.4.0", True),
("2.5.0", "2.5.0", True),
Expand Down
15 changes: 6 additions & 9 deletions torchao/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@
import functools
import importlib
import itertools
import re
import time
from functools import reduce
from importlib.metadata import version
from packaging.version import Version
from math import gcd
from typing import Any, Callable, Optional

Expand Down Expand Up @@ -354,13 +354,8 @@ def _is_float8_type(dtype: torch.dtype) -> bool:


def parse_version(version_string):
# Extract just the X.Y.Z part from the version string
match = re.match(r"(\d+\.\d+\.\d+)", version_string)
if match:
version = match.group(1)
return [int(x) for x in version.split(".")]
else:
raise ValueError(f"Invalid version string format: {version_string}")
"""Return a :class:`Version` object for the given version string."""
return Version(version_string)


def compare_versions(v1, v2):
Expand Down Expand Up @@ -768,7 +763,9 @@ def fill_defaults(args, n, defaults_tail):

## Deprecated, will be deleted in the future
def _torch_version_at_least(min_version):
return is_fbcode() or version("torch") >= min_version
# Use the same implementation as :func:`torch_version_at_least` to handle
# development and local versions correctly.
return is_fbcode() or compare_versions(torch.__version__, min_version) >= 0


# Supported AMD GPU Models and their LLVM gfx Codes:
Expand Down
Loading