[WIP] chore: basic linting/formatting/ci #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjappelbaum
changed the title
|
We certainly have time for a demo! I will also respond to your email. |
|
I thin Ayush has fixed the problems that I mentioned. |
|
Will continue working on the PR later / or we can discuss how much you want to adapt some linting/style/code layout "semi"-standards. |
|
One very useful set of tools that @kjappelbaum could share our expertise on would be employing continuous integration (via GitHub actions, for example). I was speaking about this earlier on Gather |
|
We are delighted to have your experience. We believe in testing, linting,
PEP-8 and all the other Knights of the Python Table.
At the moment we are concentrated on getting a good demo for Shweata
tomorrow, but after that we would be delighted to have your suggestions.
All codes have some, but not enough, docstrings; some but not enough tests;
some but not enough examples/tutorials.
All the code is aiming towards argparsing - docanalysis + pygetpapers has
the main framework; py4ami has a lot but is probably bloated; pyamiimage
has many tests, some examples but not yet CLI.
P.
…On Tue, Feb 8, 2022 at 4:56 PM Kevin Jablonka ***@***.***> wrote:
Will continue working on the PR later / or we can discuss how much you
want to adapt some linting/style/code layout "semi"-standards.
—
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFTCS6HSTAJMHQ3SNNDGNTU2FDMDANCNFSM5N2OATXA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you commented.Message ID:
***@***.***>
--
Peter Murray-Rust
Founder ContentMine.org
and
Reader Emeritus in Molecular Informatics
Dept. Of Chemistry, University of Cambridge, CB2 1EW, UK
|
Happy to give a demo tomorrow in one of the breaks. I can make a draft PR to whichever repo you think would be most useful, the test harness could then be used across each of these related packages |
|
In fact, I see pygetpapers already uses this, so perhaps just a demo will suffice :) |
|
one can maybe just use one of the cookiecutters ;) https://github.com/kjappelbaum/cookiecutter-snekpack (a broken fork of charlie's) |
|
Yes, I think Ayush introduced this for pygetpapers a few months back. We
haven't done it for all the code yet.
P.
…On Tue, Feb 8, 2022 at 5:41 PM Matthew Evans ***@***.***> wrote:
In fact, I see pygetpapers already uses this, so perhaps just a demo will
suffice :)
—
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFTCSYDZV5CBD7HA5HQMRDU2FIUTANCNFSM5N2OATXA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you commented.Message ID:
***@***.***>
--
Peter Murray-Rust
Founder ContentMine.org
and
Reader Emeritus in Molecular Informatics
Dept. Of Chemistry, University of Cambridge, CB2 1EW, UK
|
|
Would be happy to see cookiecutters in action. I tried this some months
back to try to structure my projects but I didn't know enough Python then.
…On Tue, Feb 8, 2022 at 6:09 PM Kevin Jablonka ***@***.***> wrote:
one can maybe just use one of the cookiecutters ;)
https://github.com/kjappelbaum/cookiecutter-snekpack (a broken fork of
charlie's)
—
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFTCS56RY2RIOTXQD3FZYTU2FL55ANCNFSM5N2OATXA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you commented.Message ID:
***@***.***>
--
Peter Murray-Rust
Founder ContentMine.org
and
Reader Emeritus in Molecular Informatics
Dept. Of Chemistry, University of Cambridge, CB2 1EW, UK
|
|
Happy to show once (i love https://timothycrosley.com/project-6-cruft for this) - unfortunately was too busy with the breakout rooms and other orga things to join the hacking room today :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, completely fine if you do not want to merge any of this - it is probably mostly my own preference (except for the things in the
setup.py).Still WIP.