Skip to content

Conversation

tshcherban
Copy link

@tshcherban tshcherban commented Sep 13, 2022

Submodules#2766

PR adds missing label collector=exporter and metrics to resolutions-exporters in postgres

@tshcherban tshcherban temporarily deployed to CI September 13, 2022 09:10 Inactive
@tshcherban tshcherban temporarily deployed to CI September 13, 2022 09:10 Inactive
@tshcherban tshcherban temporarily deployed to CI September 13, 2022 09:10 Inactive
@tshcherban tshcherban temporarily deployed to CI September 13, 2022 09:10 Inactive
@tshcherban tshcherban temporarily deployed to CI September 13, 2022 09:10 Inactive
@tshcherban tshcherban temporarily deployed to CI September 15, 2022 11:26 Inactive
@tshcherban tshcherban temporarily deployed to CI September 15, 2022 11:26 Inactive
@tshcherban tshcherban temporarily deployed to CI September 15, 2022 11:26 Inactive
@tshcherban tshcherban temporarily deployed to CI September 15, 2022 11:26 Inactive
@tshcherban tshcherban temporarily deployed to CI September 15, 2022 11:26 Inactive
@tshcherban tshcherban marked this pull request as ready for review September 15, 2022 11:47
@tshcherban tshcherban requested a review from a team as a code owner September 15, 2022 11:47
if e.collectorName != "" {
e.constantLabels["collector"] = e.collectorName
} else {
e.constantLabels["collector"] = "exporter"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default label for compatibility with our old exporter

@tshcherban tshcherban requested a review from denisok September 15, 2022 11:48
@tshcherban tshcherban merged commit d5e6046 into main Sep 15, 2022
@tshcherban tshcherban deleted the PMM-7-pg-missing-labels branch September 15, 2022 12:58
ritbl pushed a commit to heniek/postgres_exporter that referenced this pull request Mar 19, 2023
PMM-10717 Add bgwriter collector and missing label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants