Skip to content

CHORE: Support build docker image locally with make docker-build command #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

CHORE: Support build docker image locally with make docker-build command #1138

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a5547a0
CHORE: Support build docker image locally with make docker-build command
LinPr Aug 11, 2025
80497ba
Merge branch 'main' into docker-build
LinPr Aug 23, 2025
d7b72ca
Merge branch 'main' into docker-build
LinPr Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ GO_TEST_CODECOV ?=
BUILD_DATE ?= $(shell date +%FT%T%z)
GOVERSION ?= $(shell go version | cut -d " " -f3)
COMPONENT_VERSION ?= $(shell cat VERSION)
IMAGE_TAG ?= $(shell cat VERSION | cut -c 2-)
COMPONENT_BRANCH ?= $(shell git describe --always --contains --all)
PMM_RELEASE_FULLCOMMIT ?= $(shell git rev-parse HEAD)
GO_BUILD_LDFLAGS = -X main.version=${COMPONENT_VERSION} -X main.buildDate=${BUILD_DATE} -X main.commit=${PMM_RELEASE_FULLCOMMIT} -X main.Branch=${COMPONENT_BRANCH} -X main.GoVersion=${GOVERSION} -s -w
Expand Down Expand Up @@ -71,7 +72,10 @@ init: ## Install linters
cd tools && go generate -x -tags=tools

build: ## Build exporter binary using plain go build.
go build -ldflags="$(GO_BUILD_LDFLAGS)" -o $(PMM_RELEASE_PATH)/mongodb_exporter
CGO_ENABLED=0 go build -ldflags="$(GO_BUILD_LDFLAGS)" -o $(PMM_RELEASE_PATH)/mongodb_exporter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this here though?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just make sure it is static builded, make it more portable, sometimes I want to copy the builded binary to another machine, I can run it without considering the enviroment of glibc or musl


docker-build: build
docker build -t ${NAME}:${IMAGE_TAG} .

build-gssapi: ## Build exporter binary with GSSAPI support (requires CGO enabled).
CGO_ENABLED=1 go build -ldflags="$(GO_BUILD_LDFLAGS)" -tags gssapi -o $(PMM_RELEASE_PATH)/mongodb_exporter
Expand Down