Skip to content

fix(print): guard division-by-zero & correct wcorder args #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(print): guard division-by-zero & correct wcorder args #3

wants to merge 1 commit into from

Conversation

@isaeedam-ir
Copy link

  • Fixes fatal DivisionByZeroError when $realprice is 0 (email invoice PDF generation).
  • Adds guard for $wasPrice <= 0, clamps result to 0..100.
  • Corrects wcorder call to calc_precentage(new=total, was=subtotal).
  • Repro: mark multiple orders “processing” with subtotal=0 (or total=0), plugin attaches PDF → fatal.
  • Env: WP 6.8.3, WooCommerce (version), PHP 8.4.x.

@isaeedam-ir
fix(print): prevent DivisionByZero in calc_precentage and correct wco…
d253150 
…rder args

Fixes fatal DivisionByZeroError when $realprice is 0 (email invoice PDF generation).
Adds guard for $wasPrice <= 0, clamps result to 0..100.
Corrects wcorder call to calc_precentage(new=total, was=subtotal).
Repro: mark multiple orders “processing” with subtotal=0 (or total=0), plugin attaches PDF → fatal.
Env: WP 6.8.3, WooCommerce (version), PHP 8.4.x.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@isaeedam-ir