Fix self message delete #3567
Open
Fix self message delete #3567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleborile
force-pushed
the
fix-self-message-delete
branch
from
25aa91c to
0c02220
Compare
tuyuribr
reviewed
Jun 10, 2025
| const canRevoke = window.Store.MsgActionChecks.canSenderRevokeMsg(msg) || window.Store.MsgActionChecks.canAdminRevokeMsg(msg); | ||
| const isSelfMsg = msg.from.user === msg.id.remote.user && msg.id.fromMe; |
There was a problem hiding this comment.
Why not just msg.id.fromMe ?
There was a problem hiding this comment.
Because msg.id.fromMe is true even if the chat is not of the current user, but a general message sent by current user.
First check detect the current user personal chat.
|
There still be a weird behaviour: message is deleted on any wweb session but not on phone (master) session. Maybe someone who knows wweb core better can help on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Self Message delete fixed
Description
The self message sent in own chat cannot be deleted due to error
How Has This Been Tested
tested in shell:
$ const message = await client.sendMessage('[email protected]', 'todelete')
$ await message.delete()
Environment
Machine OS: Docker + Amazon Linux 2023
Phone OS: Android
Library Version: 1.27.0
WhatsApp Web Version: 2.3000.1022278655
Puppeteer Version: 18.2.1
Browser Type and Version: Chromium
Node Version: ^20
Types of changes
Checklist