-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(plugin): Skip Live Songs - Automatically skip most non-studio recordings #4093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ················
| /\b[A-Z][a-z]+,\s*[A-Z]{2}\b/, // Locations: "Oakland, CA", "London, UK" |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·····················
| /\b[A-Z][a-z]+\s+City\b/i, // Cities: "Mexico City", "New York City" |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ············
| /\b(tokyo|paris|berlin|sydney)\b/i, // More cities |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·····················
| /\b(bbc|radio|session)\b/i, // Radio sessions |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
|
||
| export const nonStudioPatterns = [ | ||
| // "Live" in specific contexts (not as part of song title) | ||
| /[\(\[]live[\)\]]/i, // "(Live)" or "[Live]" in parentheses/brackets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <no-useless-escape> reported by reviewdog 🐶
Unnecessary escape character: (.
|
|
||
| export const nonStudioPatterns = [ | ||
| // "Live" in specific contexts (not as part of song title) | ||
| /[\(\[]live[\)\]]/i, // "(Live)" or "[Live]" in parentheses/brackets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <no-useless-escape> reported by reviewdog 🐶
Unnecessary escape character: [.
|
|
||
| export const nonStudioPatterns = [ | ||
| // "Live" in specific contexts (not as part of song title) | ||
| /[\(\[]live[\)\]]/i, // "(Live)" or "[Live]" in parentheses/brackets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <no-useless-escape> reported by reviewdog 🐶
Unnecessary escape character: ).
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
| import type { SongInfo } from '@/providers/song-info'; | ||
| import { nonStudioPatterns } from './patterns'; | ||
|
|
||
| import type { SongInfo } from '@/providers/song-info'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <importPlugin/no-duplicates> reported by reviewdog 🐶
'/home/runner/work/pear-desktop/pear-desktop/src/providers/song-info.ts' imported multiple times.
| import type { SongInfo } from '@/providers/song-info'; | |
| import { nonStudioPatterns } from './patterns'; | |
| import type { SongInfo } from '@/providers/song-info'; | |
| import type { SongInfo } from '@/providers/song-info'; | |
| import { nonStudioPatterns } from './patterns'; | |
| import type { SongInfo } from '@/providers/song-info'; | ||
| import { nonStudioPatterns } from './patterns'; | ||
|
|
||
| import type { SongInfo } from '@/providers/song-info'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <importPlugin/no-duplicates> reported by reviewdog 🐶
'/home/runner/work/pear-desktop/pear-desktop/src/providers/song-info.ts' imported multiple times.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Adds a new plugin that automatically tries to skip most non-studio recordings, live performances, and concert versions of songs to ensure users only listen to studio recordings.
What does this plugin do?
The Skip Live Songs plugin monitors song titles and automatically skips to the next track when it detects patterns indicating a non-studio recording, such as:
Implementation Details
peard:update-song-infoeventpatterns.tsFiles Changed
src/plugins/skip-live-songs/index.ts- Main plugin logicsrc/plugins/skip-live-songs/patterns.ts- Pattern definitions for detecting live/non-studio recordings using regexsrc/i18n/resources/en.json- English translations for plugin name and descriptionRelated Plugins
Similar to the existing "Skip Disliked Songs" plugin, but focuses on filtering out live performances and non-studio recordings instead of user-marked dislikes.