Fix downloader plugin #4069
Fix downloader plugin #4069
Conversation
* Remove hard-coded player_id * The specific player_id is blocked now * Update youtubei.js dependency to version 16 (fixes download issues) * Specify js interpreter for sig function stuff
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| ); | ||
| const ffmpegMutex = new Mutex(); | ||
|
|
||
| Platform.shim.eval = async (data: Types.BuildScriptResult, env: Record<string, Types.VMPrimative>) => { |
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace data:·Types.BuildScriptResult,·env:·Record<string,·Types.VMPrimative> with ⏎··data:·Types.BuildScriptResult,⏎··env:·Record<string,·Types.VMPrimative>,⏎
| Platform.shim.eval = async (data: Types.BuildScriptResult, env: Record<string, Types.VMPrimative>) => { | |
| Platform.shim.eval = async ( | |
| data: Types.BuildScriptResult, | |
| env: Record<string, Types.VMPrimative>, | |
| ) => { |
| ); | ||
| const ffmpegMutex = new Mutex(); | ||
|
|
||
| Platform.shim.eval = async (data: Types.BuildScriptResult, env: Record<string, Types.VMPrimative>) => { |
There was a problem hiding this comment.
🚫 [eslint] <@typescript-eslint/require-await> reported by reviewdog 🐶
Async arrow function has no 'await' expression.
| Platform.shim.eval = async (data: Types.BuildScriptResult, env: Record<string, Types.VMPrimative>) => { | ||
| const properties = []; | ||
|
|
||
| if(env.n) { |
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ·
| if(env.n) { | |
| if (env.n) { |
| const properties = []; | ||
|
|
||
| if(env.n) { | ||
| properties.push(`n: exportedVars.nFunction("${env.n}")`) |
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ;
| properties.push(`n: exportedVars.nFunction("${env.n}")`) | |
| properties.push(`n: exportedVars.nFunction("${env.n}")`); |
| const properties = []; | ||
|
|
||
| if(env.n) { | ||
| properties.push(`n: exportedVars.nFunction("${env.n}")`) |
There was a problem hiding this comment.
🚫 [eslint] <stylistic/semi> reported by reviewdog 🐶
Missing semicolon.
| properties.push(`n: exportedVars.nFunction("${env.n}")`) | |
| properties.push(`n: exportedVars.nFunction("${env.n}")`); |
|
|
||
| const code = `${data.output}\nreturn { ${properties.join(', ')} }`; | ||
|
|
||
| return new Function(code)(); |
There was a problem hiding this comment.
🚫 [eslint] <@typescript-eslint/no-unsafe-return> reported by reviewdog 🐶
Unsafe return of a value of type any.
|
|
||
| const code = `${data.output}\nreturn { ${properties.join(', ')} }`; | ||
|
|
||
| return new Function(code)(); |
There was a problem hiding this comment.
🚫 [eslint] <@typescript-eslint/no-implied-eval> reported by reviewdog 🐶
Implied eval. Do not use the Function constructor to create functions.
|
|
||
| const code = `${data.output}\nreturn { ${properties.join(', ')} }`; | ||
|
|
||
| return new Function(code)(); |
There was a problem hiding this comment.
🚫 [eslint] <@typescript-eslint/no-unsafe-call> reported by reviewdog 🐶
Unsafe call of a(n) Function typed value.
| const code = `${data.output}\nreturn { ${properties.join(', ')} }`; | ||
|
|
||
| return new Function(code)(); | ||
| } |
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ;
| } | |
| }; |
| const code = `${data.output}\nreturn { ${properties.join(', ')} }`; | ||
|
|
||
| return new Function(code)(); | ||
| } |
There was a problem hiding this comment.
🚫 [eslint] <stylistic/semi> reported by reviewdog 🐶
Missing semicolon.
| } | |
| }; |
|
I can confirm this works, manually applied the changes and built a working version and can now download without issue. Thanks for you effort and showing what you have done. It will be interesting to see if this get pushed in to the next build, as it looks like some parties like youtubei.js, projects that use their code and others which operate similar are now not including this type of function in pre-compiled downloads, requiring individual users to manually insert/adjust the code and build a working copy themselves to gain this and other functions. Maybe a method avoiding getting in to trouble directly. |
2 participants
TLDR; the only way to fix the downloader is to upgrade youtubei.js to version 16 and specify a js interpreter.
As this comment says, the current hardcoded player id (from #3973) doesn't work anymore. At the moment, the downloader plugin won't work.
I upgraded youtubei.js to version 16, added in the snippet shown here (specifying a js interpreter), and got the downloads to work again.
Changes: