feat(builder): add "get" document handeling #41
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntOrFail` - Introduced `documentOrNew` and `documentOrFail` methods in `Builder` for better document management. - Enhanced `Connection` with `getDocument` method for fetching documents by ID. - Added `processGetDocument` and `_returnDocument` methods to `Bridge` for document retrieval. - Implemented `_sanitizeGetResponse` for processing single document responses. - Included tests for `documentOrNew` and `documentOrFail` scenarios. Because fetching documents should never feel like hide-and-seek! 😎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this Pull Request
This pull request adds a "get" implementation to the models.
Reference
Description
Since "get" is a reserved term in Eloquent, I've named the method
documentinstead. This PR introduces two new methods to all models:documentOrNewdocumentOrFailBoth methods accept an
idas their only parameter and directly utilize the Elasticsearchgetmethod to retrieve a document. ThedocumentOrFailmethod will throw an exception if the document is not found, whereasdocumentOrNewwill return a new instance of the model with theidset to the one you attempted to retrieve.Justification
I often store documents directly and know the exact
idvalues. WhilefindOrNewexists, these new methods have less overhead since they do not perform a search for the document; they directly retrieve it using Elasticsearch'sgetmethod.