-
Notifications
You must be signed in to change notification settings - Fork 405
ci(package.json): changed node version to version >=8 #951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@benhalverson thanks for this - it's a good start. Would you like to take on the additional work outlined in
|
|
@bmuenzenmeyer yep should I update all the package.json files for each package? |
|
@benhalverson yes that'd be great. Thoughts? |
|
I think thats a better idea 👍 |
Starting Oct 2018 v10.x will become an active LTS pattern-lab#870
|
There look to be other places in the code that are not yet on 10. We need to standardize. I will try to do that on this branch as time permits. |
|
@bmuenzenmeyer can you point me to which files are not on node 10 yet? |
|
I think I overstated how many instances you'd missed. I apologize for holding up this essential work.
|
|
Pushed those two additional entries to |
|
@benhalverson thank you for taking on this work!!!! ❤️ |
ci(package.json): changed node version to version >=8
#870
Summary of changes: