Skip to content

Conversation

@benhalverson
Copy link
Contributor

#870

Summary of changes:

  • Updated package.json to >=8
  • Added .nvmrc file

@benhalverson benhalverson changed the title ci(packages.json): changed node version to version >=8 ci(package.json): changed node version to version >=8 Sep 24, 2018
@bmuenzenmeyer
Copy link
Member

@benhalverson thanks for this - it's a good start. Would you like to take on the additional work outlined in
#870 ? If not, I can finish it up.

  • package.json engines
  • documentation / README / shields (top-level, core)

@benhalverson
Copy link
Contributor Author

@bmuenzenmeyer yep should I update all the package.json files for each package?
I can also update the readme. I assume it should say something like we have updated to work with the latest LTS version of node.

@bmuenzenmeyer
Copy link
Member

@benhalverson yes that'd be great.
But come to think of it, looking at https://github.com/nodejs/Release makes me think we should jump right to 10 anyways! I've always tried to track LTS

Thoughts?

@benhalverson
Copy link
Contributor Author

I think thats a better idea 👍

@bmuenzenmeyer
Copy link
Member

There look to be other places in the code that are not yet on 10. We need to standardize. I will try to do that on this branch as time permits.

@benhalverson
Copy link
Contributor Author

@bmuenzenmeyer can you point me to which files are not on node 10 yet?

@bmuenzenmeyer
Copy link
Member

bmuenzenmeyer commented Oct 19, 2018

@benhalverson

I think I overstated how many instances you'd missed. I apologize for holding up this essential work.

@bmuenzenmeyer bmuenzenmeyer merged commit 6686b19 into pattern-lab:dev Oct 19, 2018
@bmuenzenmeyer
Copy link
Member

Pushed those two additional entries to dev

@bmuenzenmeyer
Copy link
Member

@benhalverson thank you for taking on this work!!!!

❤️

@benhalverson benhalverson mentioned this pull request Dec 7, 2018
4 tasks
antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this pull request Apr 12, 2023
ci(package.json): changed node version to version >=8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants