Skip to content

Conversation

@bmuenzenmeyer
Copy link
Member

Closes #917
Closes #833
Closes #937 (I think) @piotscig can you confirm when released

Summary of changes:

  • Removes obsolete copy logic from the CLI. Core has done this from an early 3.0.0-alpha stage.
  • Removes the call to build() before serve(), since serve() does build for us and then they both set up watches, creating problems.
  • Implements commander's --no-watch correctly to provide default true with ability to set to false
    • This is a new capability for build and serve commands. For example, now you can serve your PL without watching files.
      npm run pl:serve -- --no-watch
      

@bmuenzenmeyer bmuenzenmeyer merged commit 8330127 into dev Sep 14, 2018
@bmuenzenmeyer bmuenzenmeyer deleted the 917-duplicate-output branch September 14, 2018 16:04
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 74.574% when pulling 830c568 on 917-duplicate-output into b89d0dd on dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants