[uikit-workshop] Remove copy-dist flag and logic from UIKit-Workshop #919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
hey @jbatley just checking in - I have been travelling but plan to look at this soon! |
Member
|
FYI this PR is still important to me but the gulpfile is actually going away completely as part of #920 - which I didn't fully anticipate both changes in such quick succession. apologies! |
Contributor
Author
|
Ahh right, makes sense not to update the gulp file if there is a plan to remove it! |
Member
|
Resolved! 💃 Merged! Thanks @jbatley ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #913
Summary of changes:
copyPublicfunction and calls from uikit-workshop's gulpfile